Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make types public #3560

Conversation

Ali-Usama
Copy link
Contributor

@Ali-Usama Ali-Usama commented Mar 4, 2024

This PR makes sc-network-sync types public following this issue.

Fixes #3556

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 4, 2024

User @Ali-Usama, please sign the CLA here.

@altonen altonen linked an issue Mar 4, 2024 that may be closed by this pull request
@dmitry-markin dmitry-markin requested a review from altonen March 4, 2024 13:24
@dmitry-markin
Copy link
Contributor

dmitry-markin commented Mar 4, 2024

Hmm, not sure if this should be merged into release branch and not in master. Normally we merge changes into master first and let them propagate into next release.

CC @altonen

@Ali-Usama
Copy link
Contributor Author

Hmm, not sure if this should be merged into release brunch and not in master. Normally we merge changes into master first and let them propagate into next release.

CC @altonen

But I need this to be updated in release-polkadot-v1.6.0, and it's gonna take me a lot of refactoring just to go around this simple fix :(

@altonen
Copy link
Contributor

altonen commented Mar 4, 2024

I don't think it should be merged to release-polkadot-v1.6.0. I understand why want it in 1.6.0, and granted it's a trivial change, but I don't know if this is something we can bother the release people with.

@ggwpez do you have any thoughts?

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5424419

@Ali-Usama
Copy link
Contributor Author

@altonen I'm gonna go ahead and close this PR and create a new one to be merged in the master branch

@Ali-Usama Ali-Usama closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is ExtendedPeerInfo private in release-polkadot-v1.6.0?
4 participants