Rococo Identity Migration Part 2 + Bug Fix #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
added
R0-silent
joepetrowski
changed the title
seadanda
approved these changes
Jan 16, 2024
joepetrowski
force-pushed
the
joe-rococo-post-identity-migration
branch
from
e818a7a to
903ec3d
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
georgepisaltu
approved these changes
Jan 17, 2024
joepetrowski
changed the title
ggwpez
approved these changes
Jan 17, 2024
gpestana
approved these changes
Jan 17, 2024
| } else { | ||
| // If the item doesn't exist, there is no "old" deposit, and the new one is zero, so no | ||
| // need to call rejig, it'd just be zero -> zero. | ||
| Zero::zero() |
There was a problem hiding this comment.
Based on the identity migrator impl, calling Call::poke_deposit with a non existing target will never pay any fees -- is this the expected behaviour? I guess it should be fine since the call is gated by root.
There was a problem hiding this comment.
Yeah it is gated by root, and the only use in the impl of reap_identity would return an error if the target did not exist, so it shouldn't end up calling into poke_deposit at all.
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Order: - [x] Start People Chain - [RPC node](https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frococo-people-rpc.polkadot.io#/explorer) - [x] Upgrade Rococo Relay (`EnsureRoot` -> `EnsureSigned`) (v1,006,002) - Done [here](https://rococo.subscan.io/extrinsic/0xef07e0f9dbb2b9e829305f132e6ce45d291239286e409177e20895e6687daa6c) - [x] Migrate all identities - Done, see extrinsics from [this account](https://rococo.subscan.io/account/5FyNYrBwndvBttTkGUqGGCRAXtBH4Mh8xELDaxaFywTsjDKb) - [x] Upgrade Rococo People (remove call filter) (v1,006,002) - Authorized [here](https://rococo.subscan.io/extrinsic/0xedf6a80229bd411b7ed8d3a489a767b0f773bed5c49239987a294c293a35b98b) With added: - [x] Upgrade Rococo People to fix `poke_deposit` bug (v1,006,001) - Authorized [here](https://rococo.subscan.io/extrinsic/0xd1dc3cd6e8274bd0196f8d9f13ed09f6e9c76e6a40f9786a1629f4cb22cf948d) Note: It's also possible to remove the Identity Migrator pallet from both the Relay Chain and the parachain at this time. I will leave them in for now to preserve the test cases until we run them on Kusama/Polkadot. We will also want a follow up to remove all Identity-related state from the Relay Chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order:
EnsureRoot->EnsureSigned) (v1,006,002)With added:
poke_depositbug (v1,006,001)Note:
It's also possible to remove the Identity Migrator pallet from both the Relay Chain and the parachain at this time. I will leave them in for now to preserve the test cases until we run them on Kusama/Polkadot. We will also want a follow up to remove all Identity-related state from the Relay Chain.