Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simple-mermaid optional #2878

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Make simple-mermaid optional #2878

merged 2 commits into from
Jan 8, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jan 8, 2024

This prevents it leaking std into no_std builds.

Closes: #2866

This prevents it leaking `std` into `no_std` builds.
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jan 8, 2024
@bkchr bkchr requested review from ggwpez and a team January 8, 2024 11:51
@@ -48,7 +48,7 @@ frame-executive = { default-features = false, path = "../frame/executive", optio
frame-system-rpc-runtime-api = { default-features = false, path = "../frame/system/rpc/runtime-api", optional = true }

docify = "0.2.0"
simple-mermaid = { git = "https://github.com/kianenigma/simple-mermaid.git", rev = "e48b187bcfd5cc75111acd9d241f1bd36604344b" }
simple-mermaid = { git = "https://github.com/kianenigma/simple-mermaid.git", rev = "e48b187bcfd5cc75111acd9d241f1bd36604344b", optional = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did not think about this 🧠

@bkchr bkchr merged commit 1914775 into master Jan 8, 2024
122 checks passed
@bkchr bkchr deleted the bkchr-simple-mermaid-optional branch January 8, 2024 15:45
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
This prevents it leaking `std` into `no_std` builds.

Closes: paritytech#2866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaged sp-runtime leaks std via simple-mermaid
3 participants