-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding try_state
hook for Vesting pallet
#2847
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks in the right direction, I think it would be useful to do a small refactoring on the externalities builder to make it easier to run the try state checks at the end of the tests.
Also, it would be easier for the reviewers if the feature branch is in the polkadot-sdk
repo and not on a fork of yours, so we can easily pull it and test it locally.
/tip medium (Tip for both this one and #1871) |
@Doordashcon Contributor did not properly post their account address. Make sure the pull request description (or user bio) has: "{network} address: {address}". |
/tip medium |
@ggwpez Invalid tip size. Please specify one of small, medium, large. |
/tip medium |
@ggwpez A medium (80 DOT) tip was successfully submitted for @Doordashcon (12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h on polkadot). https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/referenda |
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-digest-25-jan-2024/5837/1 |
The CI pipeline was cancelled due to failure one of the required jobs. |
Part of #239.
The invariant:
polkadot address: 12zsKEDVcHpKEWb99iFt3xrTCQQXZMu477nJQsTBBrof5k2h