Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport to master: Handling of disabled validators in backing subsystem (#1259) #2764

Merged
merged 5 commits into from
Jan 8, 2024
Merged

backport to master: Handling of disabled validators in backing subsystem (#1259) #2764

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c13fa40
Handling of disabled validators in backing subsystem (#1259)
tdimitrov Oct 20, 2023
13eec78
fix tests
ordian Dec 20, 2023
e3f267c
prdoc
ordian Dec 20, 2023
bbf9df5
prdoc: fix audience
ordian Dec 20, 2023
c6c375e
Merge branch 'master' into ao-backport-backing-disabling
ordian Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@ordian
ordian committed Dec 20, 2023
commit 13eec78a381c5be505386877f0abfea790da05e9
28 changes: 15 additions & 13 deletions polkadot/node/core/backing/src/tests/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,25 +2213,27 @@ fn validator_ignores_statements_from_disabled_validators() {

// The next step is the actual request to Validation subsystem
// to validate the `Seconded` candidate.
let expected_pov = pov;
let expected_validation_code = validation_code;
assert_matches!(
virtual_overseer.recv().await,
AllMessages::CandidateValidation(
CandidateValidationMessage::ValidateFromExhaustive(
_pvd,
_validation_code,
CandidateValidationMessage::ValidateFromExhaustive {
validation_data,
validation_code,
candidate_receipt,
_pov,
_,
timeout,
tx,
),
) if _pvd == pvd &&
_validation_code == validation_code &&
*_pov == pov && &candidate_receipt.descriptor == candidate.descriptor() &&
timeout == PvfExecTimeoutKind::Backing &&
pov,
executor_params: _,
exec_kind,
response_sender,
}
) if validation_data == pvd &&
validation_code == expected_validation_code &&
*pov == expected_pov && &candidate_receipt.descriptor == candidate.descriptor() &&
exec_kind == PvfExecKind::Backing &&
candidate_commitments_hash == candidate_receipt.commitments_hash =>
{
tx.send(Ok(
response_sender.send(Ok(
ValidationResult::Valid(CandidateCommitments {
head_data: expected_head_data.clone(),
upward_messages: Default::default(),
Expand Down