Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter votes from disabled validators in BackedCandidates in process_inherent_data #1863

Merged
merged 43 commits into from
Nov 30, 2023
Merged

Filter votes from disabled validators in BackedCandidates in process_inherent_data #1863

Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
259cb4b
Filter backing votes in `paras_inherent` - initial work
tdimitrov Oct 10, 2023
d451886
Error handling
tdimitrov Oct 12, 2023
a3bafba
Merge branch 'master' into tsv-disabling-runtime
tdimitrov Oct 16, 2023
75d707a
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Oct 16, 2023
cb0d8fc
Add `fn disabled_validators` to `trait DisabledValidators`. Use the t…
tdimitrov Oct 16, 2023
8a8893e
Extract the implementation of `disabled_validators` from rutnime api …
tdimitrov Oct 17, 2023
7b868b0
Error handling
tdimitrov Oct 17, 2023
a41d21c
Remove `DisabledValidators` from paras_inherent
tdimitrov Oct 17, 2023
34a3bf0
Fix a warning
tdimitrov Oct 17, 2023
88eb018
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Oct 23, 2023
305d5b8
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Oct 24, 2023
e241312
Add setters used for unit tests
tdimitrov Oct 26, 2023
2aa1323
Mock for `DisabledValidators` in Test runtime
tdimitrov Oct 26, 2023
a8efd15
Fix test state and add an optimisation for `filter_backed_statements`
tdimitrov Oct 26, 2023
3567a93
Make disabled validators mock mutable
tdimitrov Oct 26, 2023
04dc32a
Extract common code in `get_test_data`
tdimitrov Oct 26, 2023
cce71ee
Additional cases
tdimitrov Oct 26, 2023
7a19f55
Fixes in `filter_backed_statements`
tdimitrov Oct 26, 2023
3260187
Refactor `filter_backed_statements`
tdimitrov Oct 26, 2023
ff577a5
Merge branch 'tsv-disabling' into tsv-disabling-runtime
ordian Oct 26, 2023
876655d
Apply suggestions from code review
tdimitrov Oct 28, 2023
ed2d430
wip: Filtering backed statements from disabled validators is performe…
tdimitrov Oct 31, 2023
9a8985a
para_id_to_core_idx -> scheduled
tdimitrov Oct 31, 2023
f7544d7
Fix code duplication in tests
tdimitrov Oct 31, 2023
59fc176
Fix a compilation error
tdimitrov Oct 31, 2023
cb2fe60
Fix backing votes filtering - if more than `effective_minimum_backing…
tdimitrov Nov 2, 2023
be85b5d
Ensure inherent data contains no backing votes from disabled validato…
tdimitrov Nov 2, 2023
f472bb1
Comments and small fixes
tdimitrov Nov 2, 2023
53aaffa
Fix disabled statements filtering
tdimitrov Nov 3, 2023
16823f4
Updated comments
tdimitrov Nov 3, 2023
452b202
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Nov 6, 2023
cb60cf0
Apply suggestions from code review
tdimitrov Nov 15, 2023
750f2db
Code review feedback
tdimitrov Nov 15, 2023
7022003
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Nov 16, 2023
8b5e5a8
Apply suggestions from code review: remove duplicated assert
tdimitrov Nov 28, 2023
a50800f
Code review feedback - filter_backed_statements_from_disabled -> filt…
tdimitrov Nov 28, 2023
7a308cd
Update parainherent.md with some details about data sanitization
tdimitrov Nov 28, 2023
7ccb942
Add newline to parainherent.md
tdimitrov Nov 28, 2023
1834e20
Apply suggestions from code review
tdimitrov Nov 28, 2023
610b45d
Apply suggestions from code review
tdimitrov Nov 29, 2023
83adc93
Fixes in parainherent.md
tdimitrov Nov 29, 2023
158557d
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Nov 29, 2023
79f4c40
Merge branch 'tsv-disabling' into tsv-disabling-runtime
tdimitrov Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review: remove duplicated assert 
Co-authored-by: Maciej <[email protected]>
  • Loading branch information
@tdimitrov @Overkillus
tdimitrov and Overkillus authored Nov 28, 2023
commit 8b5e5a8622f63fe930818b0f4592b5d621134238
4 changes: 0 additions & 4 deletions polkadot/runtime/parachains/src/paras_inherent/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,10 +1469,6 @@ mod sanitizers {
backed_candidates.get(0).unwrap().validator_indices.get(0).unwrap(),
true
);
assert_eq!(
backed_candidates.get(0).unwrap().validator_indices.get(0).unwrap(),
true
);
assert_eq!(
backed_candidates.get(0).unwrap().validator_indices.get(1).unwrap(),
true
Expand Down