Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

Merged
merged 32 commits into from
Oct 24, 2023
Merged

Application Crypto and BEEFY Support for paired (ECDSA,BLS) crypto #1815

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
5d3dce1
First definition for pair public keys
drskalman Aug 3, 2023
be890d4
Two example of implementation of pair for demonestration
drskalman Aug 3, 2023
fb6a018
- implement paired crypto `Public` as tuple of two `Public`s - unsuce…
drskalman Aug 14, 2023
62ef8b1
keep both public key object and their continous serialization in pair…
drskalman Aug 21, 2023
8d4e523
implement PassBy and From<Pair> for paired_crypto
drskalman Aug 21, 2023
eea74e2
implement rest of aux traits for `paired_crypto::Public` implement so…
drskalman Aug 22, 2023
f407d87
Attempt to implement trait `Pair` for `pair_cyrpto::Pair`
drskalman Aug 29, 2023
2606cc4
- Implement trait `Pair` for `paired_crypto::Pair` - Implement a pair…
drskalman Aug 31, 2023
00933da
implement sgin and verify for
drskalman Sep 5, 2023
e7719ab
Actually implementing `paired_crypto::{Pair, Public, Signatrue}` for …
drskalman Sep 10, 2023
7a9b677
Implement and pass all test for `paired_crypto`
drskalman Sep 11, 2023
a01a814
- move to signle seed for both schemes in `primitives/core/src/paired…
drskalman Sep 25, 2023
7c02658
replace `hex!` → `array_bytes::hex2xx`
drskalman Sep 25, 2023
7f8d958
Apply suggestions from `paired_crypto` code review on type nam, hash …
drskalman Oct 5, 2023
eef2cec
Do not panic in `paired::Signature::try_from`
drskalman Oct 5, 2023
efb215f
Remove `DoublePair` trait.
drskalman Oct 5, 2023
65584bd
Do not empty implement `paired::Pair`
drskalman Oct 5, 2023
e047f75
Use `paired_crypto::Seed` instead of `[u8; SECURE_SEED_LEN]`
drskalman Oct 5, 2023
c12b82e
use `ecdsa::PUBLIC_KEY_SERIALIZED_SIZE` and `ecdsa::SIGNATURE_SERIALI…
drskalman Oct 5, 2023
dba854a
Remove `paired::DoublePair` impl as well
drskalman Oct 5, 2023
5182c86
- Implement `BytesArray` for both ecdsa and bls Signatures
drskalman Oct 5, 2023
17d0077
Implement encode_and_decode_(public_key/signature)_works test for pai…
drskalman Oct 5, 2023
a740589
cargo fmt
drskalman Oct 5, 2023
79f25e9
- Implement RuntimeAppCrypto and necessery hostApi for ecdsa_bls377 c…
drskalman Oct 6, 2023
067dece
cargo fmt
drskalman Oct 6, 2023
3cf7594
Merge branch 'master' into skalman--paired-ecdsa-bls-support-for-beef…
drskalman Oct 17, 2023
652990e
`cargo fmt`
drskalman Oct 17, 2023
388ed14
Nitpicks
davxy Oct 19, 2023
9f07bd5
implement ecdsa_bls377 `Keystore` functions for `LocalKeystore`.
drskalman Oct 20, 2023
fdd1bdf
nitpick tuple consistency
Lederstrumpf Oct 24, 2023
305a003
reuse `Ord` impl for `PartialOrd` impl of `Public`
Lederstrumpf Oct 24, 2023
3a8c46e
Merge branch 'master' into skalman--paired-ecdsa-bls-support-for-beef…
Lederstrumpf Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not empty implement paired::Pair 
Co-authored-by: Davide Galassi <[email protected]>
  • Loading branch information
@drskalman @davxy
drskalman and davxy authored Oct 5, 2023
commit 65584bd7c58229caaa390f2d9bfb7d242f82198b
9 changes: 0 additions & 9 deletions substrate/primitives/core/src/paired_crypto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,15 +557,6 @@ pub struct Pair<
}


#[cfg(feature = "full_crypto")]
impl<
LeftPair: TraitPair,
RightPair: TraitPair,
const PUBLIC_KEY_LEN: usize,
const SIGNATURE_LEN: usize,
> Pair<LeftPair, RightPair, PUBLIC_KEY_LEN, SIGNATURE_LEN>
{
}

#[cfg(feature = "full_crypto")]
impl<
Expand Down