Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when compiling Substrate node-template #2960

Closed
2 tasks done
ausipome opened this issue Jan 17, 2024 · 1 comment · Fixed by #2986
Closed
2 tasks done

error when compiling Substrate node-template #2960

ausipome opened this issue Jan 17, 2024 · 1 comment · Fixed by #2986
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@ausipome
Copy link

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

error[E0449]: visibility qualifiers are not permitted here
--> substrate/frame/contracts/src/lib.rs:1247:3
|
1247 | environmental!(executing_contract: bool);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: trait items always share the visibility of their trait
= note: this error originates in the macro environmental (in Nightly builds, run with -Z macro-backtrace for more

Steps to reproduce

This happens when compiling the node-template in the Substrate folder on WSL. I have tried to compile using the latest nightly tool chain and also rustc 1.75.0-nightly as the latest release has been tested against this.

@ausipome ausipome added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels Jan 17, 2024
bkchr added a commit that referenced this issue Jan 18, 2024
Apparently they changed detection for visibility identifiers on traits,
which broke more than it should. There is an issue open: rust-lang/rust#119924
The easy solution for us is to move the declaration of the global
variable outside of the trait.

Closes: #2960
@bkchr
Copy link
Member

bkchr commented Jan 18, 2024

Either use the latest stable release of the compiler or wait for this fix: #2986

github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2024
Apparently they changed detection for visibility identifiers on traits,
which broke more than it should. There is an issue open:
rust-lang/rust#119924 The easy solution for us
is to move the declaration of the global variable outside of the trait.

Closes: #2960
pmikolajczyk41 pushed a commit to Cardinal-Cryptography/polkadot-sdk that referenced this issue Feb 21, 2024
Apparently they changed detection for visibility identifiers on traits,
which broke more than it should. There is an issue open:
rust-lang/rust#119924 The easy solution for us
is to move the declaration of the global variable outside of the trait.

Closes: paritytech#2960
(cherry picked from commit 0e124a0)
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
Apparently they changed detection for visibility identifiers on traits,
which broke more than it should. There is an issue open:
rust-lang/rust#119924 The easy solution for us
is to move the declaration of the global variable outside of the trait.

Closes: paritytech#2960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants