Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-cli's Cors is not available publicly #2885

Closed
nazar-pc opened this issue Jan 9, 2024 · 0 comments · Fixed by #2898
Closed

sc-cli's Cors is not available publicly #2885

nazar-pc opened this issue Jan 9, 2024 · 0 comments · Fixed by #2898

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Jan 9, 2024 •
edited
Loading

There are a few data structures in sc-cli for CLI purposes, many of which are in arg_enums module, but Cors data structure for some reason is only run_cmd and while it is technically public, it is not re-exported and thus is not actually reachable from the outside.

Should it be moved to arg_enums or be re-exported from run_cmd?
@ggwpez ggwpez added this to SDK Node Jan 9, 2024
@github-project-automation github-project-automation bot moved this to backlog in SDK Node Jan 9, 2024
@nazar-pc nazar-pc mentioned this issue Jan 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 11, 2024
@nazar-pc
Move Cors data structure into reachable place (#2898)
f270b08 
Trivial refactoring, fixes
#2885
@github-project-automation github-project-automation bot moved this from backlog to done in SDK Node Jan 11, 2024
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@nazar-pc
Move Cors data structure into reachable place (paritytech#2898)
5013dab 
Trivial refactoring, fixes
paritytech#2885
bkchr pushed a commit that referenced this issue Apr 10, 2024
@serban300 @bkchr
Move generic CLI logic to different crate (#2885)
3643f72 
* Move generic CLI logic to separate crate

* Move and rename `CliChain` trait definition

Move it to `relay-substrate-client`

* Move generic cli logic to substrate-relay-helper

* Fix docs warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move Cors data structure into reachable place nazar-pc/polkadot-sdk
1 participant
@nazar-pc