Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HoldReason composite enum in instatiable pallets #1839

Closed
gpestana opened this issue Oct 10, 2023 · 0 comments · Fixed by #1857
Closed

HoldReason composite enum in instatiable pallets #1839

gpestana opened this issue Oct 10, 2023 · 0 comments · Fixed by #1857
Assignees
@gupnik
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@gpestana
Copy link
Contributor

There seems to be a problem with the HoldReason composite enum when the pallet can have multiple instances in the runtime. Given that the composite enum is implemented with a macro, the compilation error is not very helpful:

  warning: `pallet-contracts` (lib) generated 1 warning (run `cargo fix --lib -p pallet-contracts` to apply 1 suggestion)
  error[E0119]: conflicting implementations of trait `From<pallet_referenda::HoldReason>` for type `RuntimeHoldReason`
      --> /Users/gpestana/parity/polkadot-sdk/substrate/bin/node/runtime/src/lib.rs:2057:1
       |
  652  |   |     type Reward = (); // rewards are minted from the void
       |   |         ^
       |   |         |
       |   |_________first implementation here
       |             conflicting implementation for `RuntimeHoldReason`
  ...
  2057 | / / construct_runtime!(
  2058 | |       pub struct Runtime

This PR #1785 is a good place to reproduce the error.
@gpestana gpestana added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 10, 2023
@gpestana gpestana mentioned this issue Oct 10, 2023
Open
1 task
@gupnik gupnik self-assigned this Oct 10, 2023
@gupnik gupnik moved this from Backlog to In Progress in Runtime / FRAME Oct 11, 2023
@gupnik gupnik mentioned this issue Oct 12, 2023
Merged
1 task
gupnik added a commit that referenced this issue Oct 13, 2023
@gupnik
Adds instance support for composite enums (#1857)
6b27dad 
Fixes #1839

Currently, `composite_enum`s do not support pallet instances. This PR
allows the following:
```rust
	#[pallet::composite_enum]
	pub enum HoldReason<I: 'static = ()> {
		SomeHoldReason
	}
```

### Todo

- [x]  UI Test
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Oct 13, 2023
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this issue Mar 25, 2024
@gupnik
Adds instance support for composite enums (paritytech#1857)
8b127b1 
Fixes paritytech#1839

Currently, `composite_enum`s do not support pallet instances. This PR
allows the following:
```rust
	#[pallet::composite_enum]
	pub enum HoldReason<I: 'static = ()> {
		SomeHoldReason
	}
```

### Todo

- [x]  UI Test
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @bkchr
fix bridge-runtime-common build (#1839)
2657973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gupnik gupnik

Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds instance support for composite enums paritytech/polkadot-sdk
2 participants
@gpestana @gupnik