Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conviction Voting Pallet emits event on vote and remove_vote #143

Closed
2 tasks done
muharem opened this issue Jul 31, 2023 · 2 comments · Fixed by #4613
Closed
2 tasks done

Conviction Voting Pallet emits event on vote and remove_vote #143

muharem opened this issue Jul 31, 2023 · 2 comments · Fixed by #4613
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@muharem
Copy link
Contributor

muharem commented Jul 31, 2023 •
edited
Loading

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

On the successful vote, remove_vote and remove_other_vote actions there are no events emitted, which make it hard to subscribe for such an event.

Request

Emit an event on the successful vote, remove_vote and remove_other_vote.

Solution

No response

Are you willing to help with this request?

Yes!

mentor: @muharem
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed J0-enhancement labels Aug 25, 2023
@PieWol
Copy link
Contributor

PieWol commented Oct 4, 2023

Hey @muharem, would this just be creating a new event and emitting it whenever try_vote is successful? Looks pretty easy to do. If you would agree and this is still relevant I can see myself putting up a PR for it.

@muharem
Copy link
Contributor Author

muharem commented Feb 13, 2024

Hey @muharem, would this just be creating a new event and emitting it whenever try_vote is successful? Looks pretty easy to do. If you would agree and this is still relevant I can see myself putting up a PR for it.

yes, right, go ahead

@muharem muharem added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Mar 22, 2024
@muharem muharem changed the title Conviction Voting Pallet emits event on vote Conviction Voting Pallet emits event on vote and remove_vote Mar 23, 2024
@dharjeezy dharjeezy mentioned this issue May 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2024
@dharjeezy @muharem
include events for voting (#4613)
2982bf3 
closes #143

Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW

---------

Co-authored-by: Muharem <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Jul 24, 2024
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@dharjeezy @muharem @TarekkMA
include events for voting (paritytech#4613)
0beeaf1 
closes paritytech#143

Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW

---------

Co-authored-by: Muharem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include events for voting dharjeezy/polkadot-sdk
4 participants
@juangirini @muharem @PieWol @the-right-joyce