pass asset id as ref for ConversionFromAssetBalance

paritytech · Sep 14, 2023 · e64fba7 · e64fba7
1 parent 7e13f4c
commit e64fba7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/substrate/frame/asset-rate/src/lib.rs b/substrate/frame/asset-rate/src/lib.rs
@@ -234,7 +234,7 @@ where
 
 	fn from_asset_balance(
 		balance: BalanceOf<T>,
-		asset_kind: AssetKindOf<T>,
+		asset_kind: &AssetKindOf<T>,
 	) -> Result<BalanceOf<T>, pallet::Error<T>> {
 		let rate = pallet::ConversionRateToNative::<T>::get(asset_kind)
 			.ok_or(pallet::Error::<T>::UnknownAssetKind.into())?;

diff --git a/substrate/frame/asset-rate/src/tests.rs b/substrate/frame/asset-rate/src/tests.rs
@@ -135,7 +135,7 @@ fn convert_works() {
 			BalanceOf<Test>,
 			<Test as pallet_asset_rate::Config>::AssetKind,
 			BalanceOf<Test>,
-		>>::from_asset_balance(10, ASSET_ID);
+		>>::from_asset_balance(10, &ASSET_ID);
 		assert_eq!(conversion.expect("Conversion rate exists for asset"), 25);
 	});
 }
@@ -147,7 +147,7 @@ fn convert_unknown_throws() {
 			BalanceOf<Test>,
 			<Test as pallet_asset_rate::Config>::AssetKind,
 			BalanceOf<Test>,
-		>>::from_asset_balance(10, ASSET_ID);
+		>>::from_asset_balance(10, &ASSET_ID);
 		assert!(conversion.is_err());
 	});
 }
diff --git a/substrate/frame/support/src/traits/tokens/misc.rs b/substrate/frame/support/src/traits/tokens/misc.rs
@@ -270,7 +270,7 @@ pub trait ConversionFromAssetBalance<AssetBalance, AssetId, OutBalance> {
 	type Error;
 	fn from_asset_balance(
 		balance: AssetBalance,
-		asset_id: AssetId,
+		asset_id: &AssetId,
 	) -> Result<OutBalance, Self::Error>;
 }