Skip to content

Commit

Permalink
Benchmarking: Add pov_mode to V2 syntax (#3616)
Browse files Browse the repository at this point in the history
Changes:
- Port the `pov_mode` attribute from the V1 syntax to V2
- Update `pallet-whitelist` and `frame-benchmarking-pallet-pov`

Follow up: also allow this attribute on top-level benchmark modules.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
  • Loading branch information
ggwpez authored Mar 19, 2024
1 parent 430ad2f commit abd3f0c
Show file tree
Hide file tree
Showing 18 changed files with 1,085 additions and 601 deletions.
28 changes: 28 additions & 0 deletions prdoc/pr_3616.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: "Benchmarking pallet V2 syntax extension: pov_mode attribute"

doc:
- audience: Runtime Dev
description: |
Adds the `pov_mode` attribute from the V1 benchmarking syntax to the V2 syntax. This allows to
override the default PoV mode (`MaxEncodedLen`) to either `Measured` or `Ignored`. It can be
overridden for a whole benchmark, a key prefix of a specific key itself.

Example syntax looks like this:
```rust
#[benchmark(pov_mode = Measured {
Pallet: Measured,
Pallet::Storage: MaxEncodedLen,
})]
fn do_some() {
..
}
```

crates:
- name: frame-support-procedural
bump: minor
- name: frame-support
bump: minor
Loading

0 comments on commit abd3f0c

Please sign in to comment.