Added Rococo BH <> Rococo Bulletin bridge #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
bkontur
approved these changes
Dec 13, 2023
acatangiu
approved these changes
Dec 13, 2023
…use of latest changes
svyatonik
added a commit
that referenced
this pull request
Dec 15, 2023
* added Rococo BH <> Rococo Bulletin bridge * init-bridge support * allow customising finality-related runtime APIs * revert me * use Rococo/BridgeHubRococo pretending to be a Polkadot/BridgeHubPolkadot in Rococo <> RococoBulletin bridge * Revert "revert me" This reverts commit 90c598d. * Revert "allow customising finality-related runtime APIs" This reverts commit b39c32c. * fmt * WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX * regenerate bulletin chain runtime (pallet indices have changed) * fx WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX constant because of latest changes * also change indices in runtime * fmt * clippy
svyatonik
added a commit
that referenced
this pull request
Dec 15, 2023
* Added Rococo BH <> Rococo Bulletin bridge (#2724) * added Rococo BH <> Rococo Bulletin bridge * init-bridge support * allow customising finality-related runtime APIs * revert me * use Rococo/BridgeHubRococo pretending to be a Polkadot/BridgeHubPolkadot in Rococo <> RococoBulletin bridge * Revert "revert me" This reverts commit 90c598d. * Revert "allow customising finality-related runtime APIs" This reverts commit b39c32c. * fmt * WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX * regenerate bulletin chain runtime (pallet indices have changed) * fx WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX constant because of latest changes * also change indices in runtime * fmt * clippy * remove no longer valid check from the ensure_weights_are_correct (#2740) * remove no longer valid check from the ensure_weights_are_correct * fix compilation * fmt
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* added Rococo BH <> Rococo Bulletin bridge * init-bridge support * allow customising finality-related runtime APIs * revert me * use Rococo/BridgeHubRococo pretending to be a Polkadot/BridgeHubPolkadot in Rococo <> RococoBulletin bridge * Revert "revert me" This reverts commit 90c598d. * Revert "allow customising finality-related runtime APIs" This reverts commit b39c32c. * fmt * WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX * regenerate bulletin chain runtime (pallet indices have changed) * fx WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX constant because of latest changes * also change indices in runtime * fmt * clippy
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* added Rococo BH <> Rococo Bulletin bridge * init-bridge support * allow customising finality-related runtime APIs * revert me * use Rococo/BridgeHubRococo pretending to be a Polkadot/BridgeHubPolkadot in Rococo <> RococoBulletin bridge * Revert "revert me" This reverts commit 90c598d. * Revert "allow customising finality-related runtime APIs" This reverts commit b39c32c. * fmt * WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX * regenerate bulletin chain runtime (pallet indices have changed) * fx WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX constant because of latest changes * also change indices in runtime * fmt * clippy
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* Added Rococo BH <> Rococo Bulletin bridge (#2724) * added Rococo BH <> Rococo Bulletin bridge * init-bridge support * allow customising finality-related runtime APIs * revert me * use Rococo/BridgeHubRococo pretending to be a Polkadot/BridgeHubPolkadot in Rococo <> RococoBulletin bridge * Revert "revert me" This reverts commit 90c598d. * Revert "allow customising finality-related runtime APIs" This reverts commit b39c32c. * fmt * WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX * regenerate bulletin chain runtime (pallet indices have changed) * fx WITH_BRIDGE_ROCOCO_TO_BULLETIN_MESSAGES_PALLET_INDEX constant because of latest changes * also change indices in runtime * fmt * clippy * remove no longer valid check from the ensure_weights_are_correct (#2740) * remove no longer valid check from the ensure_weights_are_correct * fix compilation * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2547
The idea is to have some test environment before adding this stuff to Polkadot Bridge Hub. People chain (which will be bridged to Bulletin Chain) is being added to Rococo/Westend here: paritytech/polkadot-sdk#2281. @joepetrowski said that we'll be able to deploy another "copy" of bulletin chain to bridge with Rococo, so let's add support for Rococo <> Rococo Bulletin chain bridge then.
TODOs left here:
final decision on whether we need another two crates -actually we won't be able to change pallet names in Rococo runtime if we'll keep using Polkadot Bulletin runtime as 1:1 for Rococo Bulletin;bp_rococo_bulletin_chainandrelay-rococo-bulletin-client. Since we'll be deploying the same runtime, let's probably try to reuse Polkadot Bulletin crates? But it causes confuction - i.e. in Rococo runtime I had to useBridgePolkadotBulletinGrandpapallet name instead ofBridgeRococoBulletinGrandpa, so I'm slowly tending to adding other two crates :/