fix(http client): impl Clone #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
approved these changes
Nov 29, 2021
TarikGul
approved these changes
Nov 29, 2021
dvdplm
reviewed
Nov 29, 2021
| @@ -75,7 +75,7 @@ impl HttpClientBuilder { | |||
| .map_err(|e| Error::Transport(e.into()))?; | |||
| Ok(HttpClient { | |||
| transport, | |||
| id_manager: RequestIdManager::new(self.max_concurrent_requests), | |||
| id_manager: Arc::new(RequestIdManager::new(self.max_concurrent_requests)), | |||
There was a problem hiding this comment.
dq: could this be a Box too?
There was a problem hiding this comment.
Maybe with:
impl Clone for RequestIdManager {
fn clone(&self) -> Self {
RequestIdManager {
current_pending: self.current_pending.clone(),
max_concurrent_requests: self.max_concurrent_requests.clone(),
current_id: AtomicU64::new(self.current_id.load(std::sync::atomic::Ordering::SeqCst)),
}
}
}There was a problem hiding this comment.
Because we rely on the strong count on current_pending for how many concurrent requests cloning current_pending it increase the strong count and it will not work properly.
Thus, that's why I used Arc<RequestIdManager>.
Box only works when RequestIdManager is clone right?! I don't want it to be Clone because the reason ☝️
There was a problem hiding this comment.
Box only works when RequestIdManager is clone right?! I don't want it to be Clone because the reason ☝️
Ah, right, ok, I get it now.
Yes, RequestIdManager would have to be Clone (and if it were you wouldn't need nor Box or Arc).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #560
Heads up: request limit is shared by the client when it's cloned.