Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client(error): make display impl less verbose #1283

Merged
merged 2 commits into from
Feb 5, 2024
Merged

client(error): make display impl less verbose #1283

merged 2 commits into from
Feb 5, 2024

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Feb 2, 2024 •
edited
Loading

Resolves #1280

@niklasad1 niklasad1 requested a review from a team as a code owner February 2, 2024 15:07
jsdw
jsdw approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So basically this change restricts the body error type a bit and as such can avoid the generic boxed error (and a couple of display tweaks)?

Looks good to me!

@niklasad1
Copy link
Member Author

So basically this change restricts the body error type a bit and as such can avoid the generic boxed error (and a couple of display tweaks)?

Yepp and the soketto errors already includes quite verbose display implementation for websocket stuff. So should be nicer now :)

niklasad1
niklasad1 commented Feb 5, 2024
View reviewed changes
core/src/http_helpers.rs Outdated Show resolved Hide resolved
@niklasad1 niklasad1 merged commit 8f73dbe into master Feb 5, 2024
11 checks passed
@niklasad1 niklasad1 deleted the na-fix-1280 branch February 5, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdw jsdw jsdw approved these changes

@lexnv lexnv lexnv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core::ClientError: improve Display impl
3 participants
@niklasad1 @jsdw @lexnv