-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Release v0.19.0 #1155
chore: Release v0.19.0 #1155
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
I think the "make Server::start infallible and add fn builder()" is a breaking change isn't it, so we can't just bump the patch version here right? |
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
CHANGELOG.md
Outdated
### [Added] | ||
|
||
- added uptest new rust lib ([#1151](https://github.com/paritytech/jsonrpsee/pull/1151)) | ||
- Add subway ([#1124](https://github.com/paritytech/jsonrpsee/pull/1124)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this isn't really important (and should prolly be "Add Subway to users list"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that makes sense, will remove this since I'd place it with the same priority as chore
PRs 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This reverts commit ac70559.
Hehe I suspected this might be the case; same happened in another recent PR :) Best to work with latest rust and we can ignore gitlab for now until it's updated if need be! |
Yep exactly! Wanted to confirm that the commit tests: Change expected error to accomodate rust from gitlab will solve the issue for the gitlab runner, that to fallback to our github one. That was just to make sure we can continue with this PR while progress is being made on the CI/CD side |
Signed-off-by: Alexandru Vasile <[email protected]>
is also a breaking change so good call making this v0.19 |
[v0.19.0] - 2023-07-20
[Fixed]
debug
(#1127)MethodSinkPermit
to fix backpressure issue on concurrent subscriptions (#1126)[Changed]
Server::start
infallible and addfn builder()
(#1137)[Added]