fix: publish script to work for workspace members
#1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Apr 26, 2023
| @@ -74,24 +75,11 @@ for CRATE_DIR in ${ORDER[@]}; do | |||
| fi | |||
| done | |||
|
|
|||
| # Wait again to make sure that the new version is published and available. | |||
There was a problem hiding this comment.
Latest cargo publishdoes indeed wait for registry to available so this is not needed anymore.
niklasad1
commented
Apr 26, 2023
|
|
||
| function read_toml () { | ||
| NAME="" | ||
| VERSION="" | ||
| NAME=$(grep "^name" ./Cargo.toml | sed -e 's/.*"\(.*\)"/\1/') | ||
| VERSION=$(grep "^version" ./Cargo.toml | sed -e 's/.*"\(.*\)"/\1/') | ||
| VERSION=$(grep "^version" $DIR/Cargo.toml | sed -e 's/.*"\(.*\)"/\1/') |
There was a problem hiding this comment.
we need to read the version from the workspace Cargo.toml and not each crate
niklasad1
commented
Apr 26, 2023
| cd - > /dev/null | ||
| done | ||
|
|
||
| echo "Tagging jsonrpsee@$VERSION" | ||
| set -x | ||
| git tag -a v$VERSION -m "Version $VERSION" | ||
| git tag -a -s v$VERSION -m "Version $VERSION" |
jsdw
approved these changes
Apr 26, 2023
lexnv
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1084