This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Remove as_derivative from SafeCallFilter
#3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
added
B0-silent
|
bot rebase |
|
Rebased |
KiChjang
approved these changes
Aug 15, 2023
|
any explanations? |
It should never have been there: /// Calls that are allowed through this filter must:
...
/// 2. Cannot lead to another call being made;
|
|
I still don't understand how the rule is being made |
|
Do you use this on parachains or only the Relay? |
|
this doesn’t impact us currently it is just me unsure about the rules |
gilescope
approved these changes
Aug 15, 2023
lexnv
approved these changes
Aug 16, 2023
bkchr
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.