This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
fix debug logs & 404 on docs after new deploy #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mordamax
commented
Jan 25, 2023
mordamax
commented
- Fix for debug logs + make help clearer
- fix 404 docs after redeployment
Fix for debug logs + make help clearer
mordamax
changed the title
Bullrich
suggested changes
Jan 25, 2023
yarn-error.log
Outdated
| @@ -0,0 +1,7776 @@ | |||
| Arguments: | |||
There was a problem hiding this comment.
I guess this was an accidental commit.
Can you please delete this and add it to the .gitignore file please?
There was a problem hiding this comment.
good catch, thanks!
rzadp
reviewed
Jan 25, 2023
| @@ -54,7 +56,7 @@ export async function fetchCommandsConfiguration( | |||
| } | |||
|
|
|||
| export function getDocsUrl(commitHash: string): string { | |||
| return new URL(path.join(config.cmdBotUrl, DOCS_PATH, getDocsFilename(commitHash))).toString() | |||
| return new URL(path.join(config.cmdBotUrl, DOCS_URL_PATH, getDocsFilename(commitHash))).toString() | |||
There was a problem hiding this comment.
Using path.join in URLs is probably a mistake, as the purpose of path.join is to generate OS-specific slashes, while URLs always use /
There was a problem hiding this comment.
Although, it will work anyway, so changing it is up to you
There was a problem hiding this comment.
thanks, i'd keep it for now
mutantcornholio
approved these changes
Jan 25, 2023
Bullrich
approved these changes
Jan 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.