This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
mostly moving files around + fix the sporadic job cancelling #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mordamax
commented
Jan 5, 2023
| @@ -0,0 +1,125 @@ | |||
| import assert from "assert" | |||
| @@ -0,0 +1,49 @@ | |||
| import { Probot } from "probot" | |||
| @@ -0,0 +1,35 @@ | |||
| import { EmitterWebhookEventName } from "@octokit/webhooks/dist-types/types" | |||
| `git clone --progress --verbose --depth 1 ${ | ||
| withRef ? `--branch "$PIPELINE_SCRIPTS_REF"` : "" | ||
| } "$PIPELINE_SCRIPTS_REPOSITORY" "$PIPELINE_SCRIPTS_DIR"` | ||
| function getCiBranchName(task: Task): string { |
There was a problem hiding this comment.
this actually fixes the sporadic cancelling
| @@ -172,68 +180,6 @@ export const runCommandInGitlabPipeline = async (ctx: Context, task: Task): Prom | |||
| return getAliveTaskGitlabContext(ctx, { id: pipeline.id, projectId: pipeline.project_id, jobWebUrl: job.web_url }) | |||
| } | |||
|
|
|||
| export function getGitlabCiYmlConfig( | |||
There was a problem hiding this comment.
moved to its own file
mordamax
commented
Jan 5, 2023
| import { PullRequestError } from "src/types" | ||
| import { getLines } from "src/utils" | ||
|
|
||
| export const onIssueCommentCreated: WebhookHandler<"issue_comment.created"> = async (ctx, octokit, payload) => { |
| gcc \ | ||
| python3-dev \ | ||
| libc-dev && \ | ||
| apt-get autoremove -y |
There was a problem hiding this comment.
This all can fit nicely into the base image, having a separate CI image doesn't make much sense anymore
There was a problem hiding this comment.
@alvicsam recommended to leave as is, he will clean this up in https://github.com/paritytech/ci_cd/issues/690 💪
| @@ -10,6 +10,7 @@ import { CmdJson } from "src/schema/schema.cmd" | |||
| import { CommandRunner } from "src/shell" | |||
| import { CommandConfigs } from "src/types" | |||
|
|
|||
| export const PIPELINE_SCRIPTS_REF = "PIPELINE_SCRIPTS_REF" | |||
There was a problem hiding this comment.
just having a constant (for autocomplete) vs hardcoding as string
Co-authored-by: Yuri Volkov <[email protected]> Signed-off-by: Maksym Hlukhovtsov <[email protected]>
mutantcornholio
approved these changes
Jan 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reason was: when you run few commands with one comment (https://github.com/paritytech-stg/polkadot/pull/2#issuecomment-1372914387), it was too quick force pushing the new gitlab-ci.yml config to the same branch, so the gitlab pipeline didn't have a time to read&start a pipeline, while it was already overridden by next command
Now jobs are set in queue as they should having the task ID as variation additionally to the PR number