Fix missing content key in symbol prop when asset is removed #9627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
requested review from
marcins,
MonicaOlejniczak,
mischnic,
JakeLane,
alshdavid,
benjervis and
Nikola-3
marcins
reviewed
Apr 8, 2024
|
|
||
| let {bundleGraph} = await b.run(); | ||
|
|
||
| assert(await run(bundleGraph), 'ITS WORKING'); |
There was a problem hiding this comment.
I'm assuming without your change this test fails with the "missing key in symbol propagation" error we've been seeing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR addresses a bug in incremental symbol propagation where assets are requested for propagation even if they are no longer contained within the AssetGraph. This can happen in the following circumstance:
AssetGraphRequestbut finds some new Assets for propagation🚨 Test instructions
Integration test added
✔️ PR Todo