Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Parcel failing in Yarn PnP mode (and peer dependency warning) #9304

Closed

Conversation

wojtekmaj
Copy link
Contributor

↪️ Pull Request

This fixes the error when installing Parcel using Yarn in PnP mode:

@parcel/fs tried to access @parcel/core (a peer dependency) but it isn't provided by its ancestors

Fixes #9114

🚨 Test instructions

  • In Yarn v2/v3/v4 repository in PnP mode, run yarn add --dev parcel; yarn parcel index.html
  • After this change, it should no longer crash

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic
Copy link
Member

@parcel/core is already a peerdep of @parcel/fs, so that should be fine. This is printed as part of the error:

Ancestor breaking the chain: @parcel/node-resolver-core@npm:3.0.3
Ancestor breaking the chain: @parcel/types@npm:2.9.3

So I think the actual error is that these two use @parcel/fs but don't have @parcel/core as a (peer) dependency.

@wojtekmaj
Copy link
Contributor Author

Yes, you're right, I got it all wrong here. Sorry!

@wojtekmaj wojtekmaj closed this Oct 10, 2023
@wojtekmaj wojtekmaj deleted the fix-peer-dependency-bug branch October 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants