Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interop declaration for ESM cross bundle imports #5664

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Add interop declaration for ESM cross bundle imports #5664

merged 5 commits into from
Jan 21, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jan 15, 2021 •
edited
Loading

This is of course still wrong regarding #5662, but at least brings it in line with the other output formats (and adds a test)

Before

import {$679c7b63be557d242f596b1b4cbcc6a9$init} from "./a.js";
console.log("b", $679c7b63be557d242f596b1b4cbcc6a9$$interop$default);

After:

function $parcel$interopDefault(a) {
  return a && a.__esModule ? a.default : a;
}
import {$679c7b63be557d242f596b1b4cbcc6a9$init} from "./a.js";
var $679c7b63be557d242f596b1b4cbcc6a9$$interop$default = $parcel$interopDefault($679c7b63be557d242f596b1b4cbcc6a9$init());
console.log("b", $679c7b63be557d242f596b1b4cbcc6a9$$interop$default);

@height
Copy link

height bot commented Jan 15, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Jan 15, 2021 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.26s -13.00ms
Cached 470.00ms +37.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 429.00ms +51.00ms ⚠️
dist/legacy/index.9ff7c523.js 1.11kb +0.00b 464.00ms +66.00ms ⚠️
dist/legacy/index.html 701.00b +0.00b 464.00ms +66.00ms ⚠️
dist/legacy/index.5859ab37.css 77.00b +0.00b 739.00ms +80.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 54.00ms +13.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 53.00ms -4.00ms 🚀
dist/legacy/index.9ff7c523.js 1.11kb +0.00b 54.00ms -3.00ms 🚀
dist/modern/index.f81b5b4b.js 1.11kb +0.00b 72.00ms +15.00ms ⚠️
dist/legacy/index.html 701.00b +0.00b 55.00ms +14.00ms ⚠️
dist/modern/index.html 701.00b +0.00b 54.00ms -3.00ms 🚀
dist/legacy/index.5859ab37.css 77.00b +0.00b 54.00ms +13.00ms ⚠️
dist/modern/index.77ce15d4.css 77.00b +0.00b 54.00ms -3.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 15.55s +87.00ms
Cached 6.50s -148.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.1964b8bb.js 4.20kb +0.00b 548.00ms -42.00ms 🚀
dist/NotFound.f4adce8d.js 530.00b +0.00b 160.00ms -36.00ms 🚀

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.79m +14.23s ⚠️
Cached 2.39s +100.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.1c87caa3.js 1.11mb +0.00b 33.32s +2.31s ⚠️
dist/editorView.94307fd1.js 587.53kb +0.00b 1.10m +23.38s ⚠️
dist/popup.f5b54d01.js 169.25kb +0.00b 13.30s +841.00ms ⚠️
dist/Toolbar.453ced4a.js 99.77kb +0.00b 14.27s +2.35s ⚠️
dist/media-viewer.b4647ff4.js 72.87kb +0.00b 10.14s +1.44s ⚠️
dist/card.92b0f4f9.js 54.02kb +0.00b 7.45s +804.00ms ⚠️
dist/component.e862677c.js 30.82kb +0.00b 3.11s +1.43s ⚠️
dist/esm.572878ca.js 27.67kb +0.00b 7.91s +2.76s ⚠️
dist/component.c1c3a8ff.js 22.54kb +0.00b 3.60s +500.00ms ⚠️
dist/DatePicker.64b5aa93.js 21.20kb +0.00b 5.56s -1.89s 🚀
dist/js.63570256.js 16.55kb +0.00b 3.60s +500.00ms ⚠️
dist/dropzone.491f3481.js 16.06kb +0.00b 13.27s +3.13s ⚠️
dist/ui.bfd5ec70.js 14.21kb +0.00b 7.21s +632.00ms ⚠️
dist/workerHasher.c27b76fd.js 11.90kb +0.00b 7.77s +2.62s ⚠️
dist/component.dd6e8cc9.js 6.20kb +0.00b 3.45s +348.00ms ⚠️
dist/EmojiPickerComponent.5d345edd.js 3.62kb +0.00b 7.12s +1.98s ⚠️
dist/png-chunks-extract.8c8d635d.js 3.55kb +0.00b 3.60s +500.00ms ⚠️
dist/index.10f02a5e.css 3.46kb +0.00b 53.65s +22.63s ⚠️
dist/dropzone.c3746b5e.js 3.44kb +0.00b 13.25s +4.29s ⚠️
dist/Modal.19c70720.js 3.14kb +0.00b 1.07s -818.00ms 🚀
dist/16.624bbe22.js 2.49kb +0.00b 1.07s -600.00ms 🚀
dist/ResourcedEmojiComponent.470ee09d.js 2.15kb +0.00b 7.21s +632.00ms ⚠️
dist/date.57372c70.js 1.96kb +0.00b 4.30s +448.00ms ⚠️
dist/images.c36248a4.js 1.90kb +0.00b 4.04s +439.00ms ⚠️
dist/feedback.80c8a178.js 1.86kb +0.00b 5.36s -1.99s 🚀
dist/16.342e69d2.js 1.86kb +0.00b 3.75s +373.00ms ⚠️
dist/workerHasher.f1855576.js 1.75kb +0.00b 7.77s +2.62s ⚠️
dist/status.acecc9f0.js 1.68kb +0.00b 4.26s +418.00ms ⚠️
dist/code.6d1ec8ce.js 1.61kb +0.00b 4.25s +776.00ms ⚠️
dist/link.cda9435d.js 1.53kb +0.00b 4.31s +434.00ms ⚠️
dist/heading6.f14573d2.js 1.53kb +0.00b 4.38s +441.00ms ⚠️
dist/heading3.dede5b4c.js 1.51kb +0.00b 4.38s +441.00ms ⚠️
dist/16.9e858e4a.js 1.51kb +0.00b 3.75s +498.00ms ⚠️
dist/16.23a6fba4.js 1.46kb +0.00b 3.88s +622.00ms ⚠️
dist/emoji.5072e4af.js 1.45kb +0.00b 4.04s +440.00ms ⚠️
dist/16.186663a4.js 1.45kb +0.00b 1.07s -601.00ms 🚀
dist/16.2c3c2005.js 1.44kb +0.00b 3.92s +437.00ms ⚠️
dist/16.45c1cffe.js 1.40kb +0.00b 3.92s +438.00ms ⚠️
dist/heading5.fe670803.js 1.40kb +0.00b 4.38s +441.00ms ⚠️
dist/expand.739e3b88.js 1.38kb +0.00b 5.36s -2.09s 🚀
dist/16.8ff06a1d.js 1.36kb +0.00b 3.76s +379.00ms ⚠️
dist/16.263c691c.js 1.34kb +0.00b 1.07s -600.00ms 🚀
dist/heading2.5c4ee285.js 1.33kb +0.00b 4.38s +441.00ms ⚠️
dist/16.b7512655.js 1.32kb +0.00b 3.92s +545.00ms ⚠️
dist/16.262b91f7.js 1.31kb +0.00b 3.92s +438.00ms ⚠️
dist/mention.76dc783a.js 1.29kb +0.00b 4.16s +439.00ms ⚠️
dist/heading4.8bbff8c5.js 1.29kb +0.00b 4.38s +441.00ms ⚠️
dist/Modal.d58fb436.js 1.28kb +0.00b 3.59s +501.00ms ⚠️
dist/16.436e2680.js 1.27kb +0.00b 1.07s -601.00ms 🚀
dist/layout.d9b11ad1.js 1.27kb +0.00b 4.04s +439.00ms ⚠️
dist/16.eaa9cadb.js 1.27kb +0.00b 3.75s +373.00ms ⚠️
dist/16.06e8a68f.js 1.26kb +0.00b 3.87s +610.00ms ⚠️
dist/16.19a76383.js 1.26kb +0.00b 3.88s +622.00ms ⚠️
dist/16.e5432caf.js 1.26kb +0.00b 3.75s +492.00ms ⚠️
dist/divider.2e62a51b.js 1.25kb +0.00b 4.04s +440.00ms ⚠️
dist/quote.487996a9.js 1.25kb +0.00b 4.26s +418.00ms ⚠️
dist/component.3edf7abd.js 1.23kb +0.00b 2.79s +895.00ms ⚠️
dist/action.8161ba48.js 1.23kb +0.00b 3.93s +448.00ms ⚠️
dist/16.0629cb86.js 1.23kb +0.00b 2.79s +895.00ms ⚠️
dist/media-card-analytics-error-boundary.3d09fdec.js 1.23kb +0.00b 8.99s +2.38s ⚠️
dist/decision.cdcb6e3b.js 1.21kb +0.00b 4.30s +701.00ms ⚠️
dist/panel-warning.8b68f633.js 1.21kb +0.00b 4.26s +528.00ms ⚠️
dist/16.cd483156.js 1.18kb +0.00b 3.92s +528.00ms ⚠️
dist/list.e0e1a7a9.js 1.18kb +0.00b 4.16s +277.00ms ⚠️
dist/heading1.a939a2da.js 1.18kb +0.00b 5.30s +1.46s ⚠️
dist/panel-error.210bc7a0.js 1.11kb +0.00b 4.16s +438.00ms ⚠️
dist/panel.8b5546b1.js 1.10kb +0.00b 4.26s +418.00ms ⚠️
dist/table.4e67906a.js 1.09kb +0.00b 4.26s +418.00ms ⚠️
dist/panel-success.a2e1eac9.js 1.05kb +0.00b 4.16s +441.00ms ⚠️
dist/panel-note.8e008c33.js 1.05kb +0.00b 4.16s +438.00ms ⚠️
dist/media-picker-analytics-error-boundary.a20da0c5.js 1003.00b +0.00b 13.25s +4.01s ⚠️
dist/media-card-analytics-error-boundary.ef6306e0.js 999.00b +0.00b 8.97s +2.39s ⚠️
dist/media-card-analytics-error-boundary.889a764d.js 999.00b +0.00b 10.84s -1.44s 🚀
dist/simpleHasher.d91ba9fe.js 755.00b +0.00b 7.77s +2.62s ⚠️
dist/index.html 119.00b +0.00b 2.45s +964.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.8c8a1d4a.js 2.43mb +0.00b 488.00ms +28.00ms ⚠️
dist/editorView.94307fd1.js 587.53kb +0.00b 563.00ms +41.00ms ⚠️
dist/popup.ab185144.js 169.17kb +0.00b 558.00ms +37.00ms ⚠️
dist/Toolbar.c11cfac5.js 99.68kb +0.00b 563.00ms +41.00ms ⚠️
dist/card.8b7fed58.js 51.68kb +0.00b 557.00ms +41.00ms ⚠️
dist/Modal.148d3acc.js 39.01kb +0.00b 488.00ms +29.00ms ⚠️
dist/component.e862677c.js 30.82kb +0.00b 488.00ms +29.00ms ⚠️
dist/component.c1c3a8ff.js 22.54kb +0.00b 478.00ms +69.00ms ⚠️
dist/DatePicker.2e53d84e.js 21.12kb +0.00b 518.00ms +50.00ms ⚠️
dist/smartMediaEditor.60d9f6fb.js 16.76kb +0.00b 563.00ms +42.00ms ⚠️
dist/js.63570256.js 16.55kb +0.00b 478.00ms +69.00ms ⚠️
dist/dropzone.3a647f2f.js 16.00kb +0.00b 558.00ms +43.00ms ⚠️
dist/component.dd6e8cc9.js 6.20kb +0.00b 478.00ms +69.00ms ⚠️
dist/png-chunks-extract.8c8d635d.js 3.55kb +0.00b 478.00ms +69.00ms ⚠️
dist/index.10f02a5e.css 3.46kb +0.00b 565.00ms +41.00ms ⚠️
dist/dropzone.c3746b5e.js 3.44kb +0.00b 558.00ms +37.00ms ⚠️
dist/Modal.19c70720.js 3.14kb +0.00b 472.00ms +73.00ms ⚠️
dist/clipboard.84ebdbd2.js 2.97kb +0.00b 558.00ms +43.00ms ⚠️
dist/16.624bbe22.js 2.49kb +0.00b 472.00ms +72.00ms ⚠️
dist/date.57372c70.js 1.96kb +0.00b 494.00ms +54.00ms ⚠️
dist/images.c36248a4.js 1.90kb +0.00b 496.00ms +53.00ms ⚠️
dist/feedback.80c8a178.js 1.86kb +0.00b 518.00ms +50.00ms ⚠️
dist/16.342e69d2.js 1.86kb +0.00b 490.00ms +64.00ms ⚠️
dist/browser.00e50e54.js 1.82kb +0.00b 557.00ms +41.00ms ⚠️
dist/16.d173f3df.js 1.79kb +0.00b 483.00ms +66.00ms ⚠️
dist/workerHasher.cbff2c2b.js 1.75kb +0.00b 557.00ms +36.00ms ⚠️
dist/list-number.9bb92c49.js 1.68kb +0.00b 498.00ms +51.00ms ⚠️
dist/status.acecc9f0.js 1.68kb +0.00b 504.00ms +52.00ms ⚠️
dist/code.6d1ec8ce.js 1.61kb +0.00b 498.00ms +58.00ms ⚠️
dist/link.cda9435d.js 1.53kb +0.00b 498.00ms +54.00ms ⚠️
dist/heading6.f14573d2.js 1.53kb +0.00b 514.00ms +46.00ms ⚠️
dist/heading3.dede5b4c.js 1.51kb +0.00b 514.00ms +46.00ms ⚠️
dist/16.9e858e4a.js 1.51kb +0.00b 488.00ms +62.00ms ⚠️
dist/16.adfefbb7.js 1.46kb +0.00b 483.00ms +66.00ms ⚠️
dist/16.23a6fba4.js 1.46kb +0.00b 483.00ms +66.00ms ⚠️
dist/emoji.5072e4af.js 1.45kb +0.00b 495.00ms +52.00ms ⚠️
dist/16.186663a4.js 1.45kb +0.00b 472.00ms +73.00ms ⚠️
dist/16.2c3c2005.js 1.44kb +0.00b 498.00ms +67.00ms ⚠️
dist/16.45c1cffe.js 1.40kb +0.00b 498.00ms +67.00ms ⚠️
dist/heading5.fe670803.js 1.40kb +0.00b 514.00ms +46.00ms ⚠️
dist/expand.739e3b88.js 1.38kb +0.00b 518.00ms +50.00ms ⚠️
dist/16.8ff06a1d.js 1.36kb +0.00b 492.00ms +62.00ms ⚠️
dist/16.263c691c.js 1.34kb +0.00b 472.00ms +72.00ms ⚠️
dist/heading2.5c4ee285.js 1.33kb +0.00b 514.00ms +46.00ms ⚠️
dist/16.b7512655.js 1.32kb +0.00b 492.00ms +62.00ms ⚠️
dist/16.262b91f7.js 1.31kb +0.00b 498.00ms +58.00ms ⚠️
dist/mention.76dc783a.js 1.29kb +0.00b 504.00ms +57.00ms ⚠️
dist/heading4.8bbff8c5.js 1.29kb +0.00b 514.00ms +46.00ms ⚠️
dist/Modal.d58fb436.js 1.28kb +0.00b 478.00ms +69.00ms ⚠️
dist/16.436e2680.js 1.27kb +0.00b 472.00ms +73.00ms ⚠️
dist/layout.d9b11ad1.js 1.27kb +0.00b 498.00ms +55.00ms ⚠️
dist/16.eaa9cadb.js 1.27kb +0.00b 490.00ms +64.00ms ⚠️
dist/16.06e8a68f.js 1.26kb +0.00b 483.00ms +66.00ms ⚠️
dist/16.19a76383.js 1.26kb +0.00b 488.00ms +62.00ms ⚠️
dist/16.e5432caf.js 1.26kb +0.00b 488.00ms +62.00ms ⚠️
dist/16.62eaafc3.js 1.26kb +0.00b 482.00ms +65.00ms ⚠️
dist/divider.2e62a51b.js 1.25kb +0.00b 495.00ms +52.00ms ⚠️
dist/quote.487996a9.js 1.25kb +0.00b 504.00ms +52.00ms ⚠️
dist/component.3edf7abd.js 1.23kb +0.00b 488.00ms +28.00ms ⚠️
dist/action.8161ba48.js 1.23kb +0.00b 498.00ms +58.00ms ⚠️
dist/16.0629cb86.js 1.23kb +0.00b 488.00ms +28.00ms ⚠️
dist/decision.cdcb6e3b.js 1.21kb +0.00b 494.00ms +54.00ms ⚠️
dist/panel-warning.8b68f633.js 1.21kb +0.00b 505.00ms +54.00ms ⚠️
dist/16.cd483156.js 1.18kb +0.00b 492.00ms +61.00ms ⚠️
dist/list.e0e1a7a9.js 1.18kb +0.00b 498.00ms +51.00ms ⚠️
dist/heading1.a939a2da.js 1.18kb +0.00b 505.00ms +37.00ms ⚠️
dist/panel-error.210bc7a0.js 1.11kb +0.00b 505.00ms +58.00ms ⚠️
dist/panel.8b5546b1.js 1.10kb +0.00b 505.00ms +54.00ms ⚠️
dist/table.4e67906a.js 1.09kb +0.00b 505.00ms +37.00ms ⚠️
dist/panel-success.a2e1eac9.js 1.05kb +0.00b 505.00ms +54.00ms ⚠️
dist/panel-note.8e008c33.js 1.05kb +0.00b 505.00ms +58.00ms ⚠️
dist/media-picker-analytics-error-boundary.a20da0c5.js 1003.00b +0.00b 558.00ms +37.00ms ⚠️
dist/media-card-analytics-error-boundary.889a764d.js 999.00b +0.00b 557.00ms +41.00ms ⚠️
dist/simpleHasher.b4d19bac.js 755.00b +0.00b 557.00ms +36.00ms ⚠️
dist/index.html 119.00b +0.00b 442.00ms +48.00ms ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 10.87s +93.00ms
Cached 454.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.59kb +0.00b 79.00ms +4.00ms ⚠️

Click here to view a detailed benchmark overview.

@mischnic mischnic mentioned this pull request Jan 15, 2021
Merged
2 tasks
@mischnic mischnic merged commit 89bc35f into v2 Jan 21, 2021
@mischnic mischnic deleted the esm-cross-bundle-interop branch January 21, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbinnssmith wbinnssmith wbinnssmith approved these changes

@devongovett devongovett Awaiting requested review from devongovett

Assignees
No one assigned
Labels
🌳 Scope Hoisting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @parcel-benchmark @wbinnssmith