-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put filewatcher in a worker, for better stability and performance #1368
Conversation
…arcel into feature/chokidar-worker
Tests pass now, only the Cargo one fails which is unrelated to this PR |
hmm interesting idea. what do you think about using our existing worker infra in parcel for this? |
@devongovett Thought it would be a better idea to make it lightweight. Sent with GitHawk |
@devongovett I've added some benchmarks, as I've just discovered after running the inspector on a project that it also boosts dev builds on non windows machines quite a lot |
This PR puts FSWatcher into a worker, this helps to add extra stability.
Fixes:
Some tests I've done on performance:
fswatcher-child
: https://github.com/DeMoorJasper/fswatcher-childCloses #1342 Closes #1331 Closes #1394 Closes #1357 Closes #1308