Support node: prefix for CJS dependencies (#9244)

parcel-bundler · Sep 14, 2023 · 3d7a353 · 3d7a353
1 parent d095514
commit 3d7a353
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/utils/node-resolver-rs/src/lib.rs b/packages/utils/node-resolver-rs/src/lib.rs
@@ -2297,6 +2297,18 @@ mod tests {
         .0,
       Resolution::Builtin("zlib".into())
     );
+    assert_eq!(
+      test_resolver()
+        .resolve(
+          "node:fs/promises",
+          &root().join("foo.js"),
+          SpecifierType::Cjs
+        )
+        .result
+        .unwrap()
+        .0,
+      Resolution::Builtin("fs/promises".into())
+    );
   }
 
   #[test]

diff --git a/packages/utils/node-resolver-rs/src/specifier.rs b/packages/utils/node-resolver-rs/src/specifier.rs
@@ -136,8 +136,9 @@ impl<'a> Specifier<'a> {
             }
           }
           SpecifierType::Cjs => {
-            if BUILTINS.contains(&specifier) {
-              (Specifier::Builtin(Cow::Borrowed(specifier)), None)
+            let builtin = specifier.strip_prefix("node:").unwrap_or(specifier);
+            if BUILTINS.contains(&builtin) {
+              (Specifier::Builtin(Cow::Borrowed(builtin)), None)
             } else {
               #[cfg(windows)]
               if !flags.contains(Flags::ABSOLUTE_SPECIFIERS) {