New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracing: Migrate to new otelgrpc tracing APIs #2237

Closed

kakkoyun opened this issue Nov 15, 2023 · 0 comments · Fixed by #2329

Labels

good first issue

Member

kakkoyun commented Nov 15, 2023

Interceptors are deprecated in favor of NewStatsHandler. Migrate to new APIs.
open-telemetry/opentelemetry-go-contrib#4534

kakkoyun added the good first issue label

Namanl2001 mentioned this issue

migrated to new otelgrpc API for tracing #2329

Merged

kakkoyun closed this as completed in #2329

kakkoyun added a commit that referenced this issue


          migrated to new otelgrpc API for tracing (#2329)

c0c0c9b

### Why?
<!-- author to complete -->
<!-- Please explain to us why we need this change. -->
Fixes : #2237 

### What?
<!-- Please explain to us what does it do? Or let the copilot handle it.
-->
migrated to new otelgrpc API for tracing.

Took reference from
[here](https://github.com/open-telemetry/opentelemetry-go-contrib/pull/4534/files#diff-45cde3191bd791caddf95c9ecc377397c29d85b4a4bfe81c5e5afbb5489d2ca7)

### How?
<!-- Please explain to us how should it work? Or let the copilot handle
it. -->

### Test Plan
<!-- How did you test it? How can we test it? -->
Screen shots from jaeger UI run using `scripts/local-observability` 


![image](https://github.com/parca-dev/parca-agent/assets/56021229/5abca66c-5b76-4309-8140-3085f0c26a23)


![image](https://github.com/parca-dev/parca-agent/assets/56021229/7725c877-56ce-43f5-9bdb-c6ea4be4cee3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment