Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm/tests: Ignore test_root_key_check case #755

Conversation

tgonzalezorlandoarm
Copy link
Member

Current situation:

  1. The test depends on a TPM being available in the system.
  2. The connection settings to the TPM have to be changed to be in line with the TPM available in the system. Currently, the hardcoded settings are set to test with the software TPM enabled by the CI.

Therefore:

  • Ignore the test by default. Each developer can run their tests according to the TPM configuration if it's needed.
  • Explicitly run the test in CI to make sure this is tested at least with the software TPM.

Current situation:

 1. The test depends on a TPM being available in the system.
 2. The connection settings to the TPM have to be changed to be
    in line with the TPM available in the system.
    Currently, the hardcoded settings are set to test with the
    software TPM enabled by the CI.

Therefore:

 * Ignore the test by default. Each developer can run their tests
   according to the TPM configuration if it's needed.
 * Explicitly run the test in CI to make sure this is tested at
   least with the software TPM.

Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Mar 28, 2024
@tgonzalezorlandoarm tgonzalezorlandoarm requested a review from a team as a code owner March 28, 2024 14:03
@tgonzalezorlandoarm tgonzalezorlandoarm requested review from ionut-arm and gowthamsk-arm and removed request for gowthamsk-arm March 28, 2024 14:03
Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 9aeb04b into parallaxsecond:main Mar 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants