structopt: Migrate to clap #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgonzalezorlandoarm
commented
Mar 18, 2024
tgonzalezorlandoarm
commented
Following the unused_qualifications lint when building with Rust Nightly, remove the errors caused by the lint. Signed-off-by: Tomás González <[email protected]>
According to TeXitoi/structopt#525, structopt has entered maintenance mode, and clap should be used for new development. Migrate to clap so that nightly builds succeed as well. Signed-off-by: Tomás González <[email protected]>
4.3.24 is the highest clap version that is compatible with the current MSRV (1.66.0) * Fix clap_lex to 0.5.0 to be compatible with MSRV as well. * Fix anstyle to 1.0.2 to be compatible with MSRV as well. * Fix anstyle-query to 1.0.0 to be compatible with MSRV as well. * Fix anstyle-parse to 0.2.1 to be compatible with MSRV as well. Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
This was referenced Mar 18, 2024
|
Please note this changes the exception list for dependency mismatch for parsec to include heck, which seems unavoidable |
|
This is supposed to solve the issues in https://github.com/parallaxsecond/parsec/actions/runs/8319327971/job/22762462593 |
|
I triggered a nightly run in here: https://github.com/tgonzalezorlandoarm/parsec/actions/runs/8328515939 |
|
The failure in the CI mismatch check is in teh parsec-tool and is expected, as the same change is coming with this pr: parallaxsecond/parsec-tool#125 |
|
Please refer to TeXitoi/structopt#525 for more information |
tgonzalezorlandoarm
merged commit aa89ce9
into
parallaxsecond:main
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.