.cargo/config.toml: remove #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This hasn't been tested yet, I didn't look into firing up the CI. But it looks like the This fixes building on an aarch64 host. |
|
Ahh OK, I looked through the docker hub testing locally now will upload a fix. |
When compiling on an aarch64 host, the override of the linker to the cross "compiler" (uses the gcc frontend) causes a build failure. Theirs no reason to set these globally for all developers as their build host may be different as well as their toolchain preference and naming conventions. Instead override the target specific linker variable in a --config option string in the cross compilation tests. Signed-off-by: Bill Roberts <[email protected]>
billatarm
force-pushed
the
fix-linking-on-aarch64-host
branch
from
0540e12 to
cf2707f
Compare
Had the key wrong and some minor TOML formatting issues. I have working locally now, lets see what the CI thinks. |
tgonzalezorlandoarm
approved these changes
Dec 7, 2023
gowthamsk-arm
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on an aarch64 host, the override of the linker to the cross "compiler" (uses the gcc frontend) causes a build failure. Theirs no reason to set these globally for all developers as their build host may be different as well as their toolchain preference and naming conventions.
Instead override the target specific linker variable in a --config option string in the cross compilation tests.