dependency_cross_matcher job: Move to PR runs and minor refactoring #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitflags crate was recently updated to 2.4.1 in the Cargo.lock files. * Update the exceptions list in dependency_cross_matcher.py to reflect said change. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
added
testing
Script was showing only the mismatches of the project but was not showing the allowed dependencies, which made it hard to spot the actual issue. Signed-off-by: Tomás González <[email protected]>
The dependency mismatcher job should run on each PR to spot issues as soon as possible. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitflags crate was recently updated to 2.4.1 in the Cargo.lock files. This has shown potential improvements on the job, as a new mismatch appeared in the nightly when we could easily have discovered it in a normal CI run.