Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci.yml: Trigger docker image creation only on workflow_dispatch #736

Merged
merged 1 commit into from
Nov 15, 2023
Merged

ci.yml: Trigger docker image creation only on workflow_dispatch #736

merged 1 commit into from
Nov 15, 2023

Conversation

tgonzalezorlandoarm
Copy link
Member

  • Simplify the docker creation process to avoid having to push a new commit with changes to the codebase.
  • Now it will only be necessary to trigger the CI workflow manually with the input 'parsec-service-test-all'.

@tgonzalezorlandoarm tgonzalezorlandoarm self-assigned this Nov 14, 2023
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/docker-creation branch 2 times, most recently from d1b3c12 to 3ba79a5 Compare November 14, 2023 14:13
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as draft November 14, 2023 14:15
@tgonzalezorlandoarm tgonzalezorlandoarm marked this pull request as ready for review November 14, 2023 14:36
@tgonzalezorlandoarm
Copy link
Member Author

Manual run: https://github.com/tgonzalezorlandoarm/parsec/actions/runs/6865120749

@tgonzalezorlandoarm
ci.yml: Trigger docker image creation only on workflow_dispatch
781083a 
 * Simplify the docker creation process to avoid having to push a
   new commit with changes to the codebase.
 * Now it will only be necessary to trigger the CI workflow manually
   with the input 'parsec-service-test-all'.

Signed-off-by: Tomás González <[email protected]>
gowthamsk-arm
gowthamsk-arm approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 42368ca into parallaxsecond:main Nov 15, 2023
13 checks passed
@tgonzalezorlandoarm tgonzalezorlandoarm deleted the tg/docker-creation branch November 23, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gowthamsk-arm gowthamsk-arm gowthamsk-arm approved these changes

@mohamedasaker-arm mohamedasaker-arm Awaiting requested review from mohamedasaker-arm

Assignees

@tgonzalezorlandoarm tgonzalezorlandoarm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgonzalezorlandoarm @gowthamsk-arm