ci/nightly: Compare parsec and parsec-tool dependency versions #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triggered Nightly check: Note: This one should fail as parsec is currently using a different version of rustix |
tgonzalezorlandoarm
force-pushed
the
tg/deps-matching-w-parsec
branch
from
d4a6f85 to
543db89
Compare
tgonzalezorlandoarm
force-pushed
the
tg/deps-matching-w-parsec
branch
from
543db89 to
d79836c
Compare
utils/dependency_cross_matcher.py
Outdated
| if args.compare: | ||
| parsec_repo, parsec_tool_repo = args.deps_dir | ||
| mismatches_parsec = run_deps_mismatcher(run_cargo_tree(parsec_repo)) | ||
| mismatches_parsec_tool = run_deps_mismatcher(run_cargo_tree(parsec_tool_repo)) |
There was a problem hiding this comment.
I think the parsec service needs a few additional flags in the cargo tree command right?
There was a problem hiding this comment.
Thanks for noticing! Well spotted
tgonzalezorlandoarm
force-pushed
the
tg/deps-matching-w-parsec
branch
from
d79836c to
04e8114
Compare
* Print error information on the dependency mismatch checker instead of doing so in the ci.sh script. This simplifies the logic and reduces maintainability efforts. Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/deps-matching-w-parsec
branch
2 times, most recently
from
df3ef09 to
263202d
Compare
parsec and parsec-tool share some dependencies. In those shared dependencies, the used versions should be the same. * Modify utils/dependency_cross_matcher.py to cover the case of comparing parsec and parsec-tool dependencies as well as the previous case of checking mismatches in parsec-tool dependencies. Signed-off-by: Tomás González <[email protected]>
We could easily discover mismatches in a normal CI run instead of in a nightly run. * Update the mismatcher job so that it's run on each PR instead of on a nightly. Signed-off-by: Tomás González <[email protected]>
* Use the newly added --compare option in utils/dependency_cross_matcher.py to compare dependencies between parsec and parsec-tool to spot common dependencies that are being used with different versions. Signed-off-by: Tomás González <[email protected]>
Keep rustix updated and avoid a dependency mismatch with parsec. Please check: parallaxsecond/parsec#741 Signed-off-by: Tomás González <[email protected]>
Signed-off-by: Tomás González <[email protected]>
tgonzalezorlandoarm
force-pushed
the
tg/deps-matching-w-parsec
branch
from
263202d to
0d6b9de
Compare
|
Once this is merged, I will create a PR in https://github.com/parallaxsecond/parsec to keep the tests synced. |
gowthamsk-arm
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #115 . Please only review when this one is merged.
Closes parallaxsecond/parsec#360