Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to mbedtls version to 3.0.0 #33

Merged

Conversation

gowthamsk-arm
Copy link
Contributor

Mbedtls version 3.0.0 has some changes which are not compatible with the parsec-se-driver. This MR contains the following changes:

  • Migrate to mbedtls 3.0.0 in ci.sh and yml files
  • Use correct NVChip file path as the docker image is updated
  • Update se driver struct element names
  • Migrate to new names of ECC Family Macros

Signed-off-by: Gowtham Suresh Kumar [email protected]

The psa-crypto crate is using mbedtls 3.0.0 which has few header
files missing in 2.27.0. As se driver uses psa-crypto internally
we need to migrate to 3.0.0.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The parsec-service-test-all docker image in GHCR has been updated
to support ondisk and sqlite managers. This commit updates the
path to use the right NVChip file.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
The mbedtls 3.0.0 has an updated naming for psa_drv_se_t,
psa_drv_se_key_management_t, and psa_drv_se_asymmetric_t
structure elements with "private_". This commit updates it.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
In mbedtls 3.0.0, the ECC Family Macros are renamed according to
PSA Spec. This commit updates the ECC macro used.

Signed-off-by: Gowtham Suresh Kumar <[email protected]>
@gowthamsk-arm gowthamsk-arm force-pushed the update_mbedtls_version branch from f6849cf to 78bb6ea Compare January 17, 2023 17:32
Copy link

@adamjohnstonarm adamjohnstonarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link

@mohamedasaker-arm mohamedasaker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should perhaps port the changes from #31 as well.

@gowthamsk-arm
Copy link
Contributor Author

@adamjohnstonarm suggested having a separate MR.
Once this is merged. Will get #31 rebased.

@gowthamsk-arm gowthamsk-arm merged commit bd1a8ab into parallaxsecond:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants