Use hexadecimal format for opcode values #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a link checker on the CI. Signed-off-by: Hugues de Valon <[email protected]>
| /// ListKeys operations | ||
| ListKeys = 26, | ||
| ListKeys = 0x001A, |
There was a problem hiding this comment.
Any reason why there's a sudden discontiguous jump from 19 to 26 here? Are we anticipating some missing PSA Crypto operations in the gap?
There was a problem hiding this comment.
It does seem as if some of the operations that are in the book aren't added here yet: https://parallaxsecond.github.io/parsec-book/parsec_client/operations/psa_verify_message.html this is 0x19
There was a problem hiding this comment.
The book contains documentation for all operations (and there are protobuf contracts too), including ones not yet present in Parsec but I had to pick op codes, which is why there is a gap. e.g.
There was a problem hiding this comment.
Thank you very much! This looks fine to me, in that case.
ionut-arm
approved these changes
Oct 8, 2020
paulhowardarm
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a link checker on the CI.
Close #82
Signed-off-by: Hugues de Valon [email protected]