Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): fixes impl of eth api for OP #9377

Merged
merged 5 commits into from
Jul 9, 2024
Merged

fix(op): fixes impl of eth api for OP #9377

merged 5 commits into from
Jul 9, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jul 8, 2024

Closes #9325

Fixes buggy/incomplete impl of EthApiServer helper traits for OpEthApi.

@emhane emhane added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jul 8, 2024
@mattsse
Copy link
Collaborator

mattsse commented Jul 8, 2024

looks like op feature issue

@emhane emhane enabled auto-merge July 9, 2024 14:15
@emhane emhane force-pushed the emhane/op-ethapi branch from 8181e1a to e5113da Compare July 9, 2024 18:30
@emhane emhane added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 63c8a82 Jul 9, 2024
33 checks passed
@emhane emhane deleted the emhane/op-ethapi branch July 9, 2024 19:02
smatthewenglish pushed a commit to smatthewenglish/reth that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add required trait impls for OpEthApi
2 participants