feat(pruner, metrics): skip attribute for metrics derive macro
#4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
... and 8 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattsse
approved these changes
Aug 7, 2023
Comment on lines
+317
to
+321
| Meta::Path(path) if path.is_ident("skip") => skip = true, | ||
| Meta::NameValue(kv) => { | ||
| let lit = match kv.value { | ||
| Expr::Lit(ref expr) => &expr.lit, | ||
| _ => continue, |
mattsse
added
C-enhancement
rkrasiuk
requested changes
Aug 7, 2023
| .fold( | ||
| (vec![], vec![], vec![]), | ||
| |(mut defaults, mut labeled_defaults, mut describes), | ||
| (default, labeled_default, describe)| { |
There was a problem hiding this comment.
let's avoid using keywords as var names
There was a problem hiding this comment.
ah, didn't know it's a keyword from nightly feature, fixed
…know which one to use instead
mattsse
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to skip certain struct fields which are not intended to be parsed as metrics:
reth/crates/prune/src/metrics.rs
Lines 5 to 12 in bf37faf