test(db): complete DatabaseProviderFactory impl for MockEthProvider #14605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
rakita,
joshieDo and
shekhirin
as code owners
fgimenez
added
A-db
fgimenez
deleted the
fgimenez/update-database-provider-factory-mock-impl
branch
fgimenez
added a commit
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #14376
Extracted from #14482
ConsistentDBViewusesDatabaseProviderFactory::database_provider_rofor the provider it uses to perform consistency checks on the current tipreth/crates/storage/provider/src/providers/consistent_view.rs
Line 71 in c5df8fb
In the current impl of that method for
MockEthProviderwe just return an error. These changes add a proper implementation to use the mock in scenarios whereConsistentDbViewis at play (like engine unit tests). TheProviderandProviderRWassociated types are set toSelfso that we can leverage the existing methods to setup the mock state.