Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store eof bytecode with header in compact #10375

Closed
wants to merge 2 commits into from

Conversation

onbjerg
Copy link
Collaborator

@onbjerg onbjerg commented Aug 17, 2024

Cherry-picked from frontiers changes

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior E-prague Related to the prague network upgrade labels Aug 17, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and let's create an issue to fix this hack

@onbjerg
Copy link
Collaborator Author

onbjerg commented Aug 17, 2024

Will adjust the test after I open up the remaining cherry pick PRs and create a follow up issue to resolve before Prague is live

@rkrasiuk
Copy link
Member

@onbjerg requires revm bump?

@onbjerg onbjerg marked this pull request as draft August 17, 2024 21:43
@onbjerg
Copy link
Collaborator Author

onbjerg commented Aug 20, 2024

yep..

@onbjerg onbjerg added the S-blocked This cannot more forward until something else changes label Aug 20, 2024
@onbjerg
Copy link
Collaborator Author

onbjerg commented Aug 28, 2024

Superseded by #10537

@onbjerg onbjerg closed this Aug 28, 2024
@onbjerg onbjerg deleted the onbjerg/eof-bytecode-encdec branch September 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior E-prague Related to the prague network upgrade S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants