Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove revm helper functions from primitives #8365

Closed
mattsse opened this issue May 23, 2024 · 0 comments · Fixed by #9152
Closed

remove revm helper functions from primitives #8365

mattsse opened this issue May 23, 2024 · 0 comments · Fixed by #9152
Assignees
@joshieDo
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented May 23, 2024 •
edited
Loading

Describe the feature

blocked by #7391

reth/crates/primitives/src/revm/config.rs

Lines 3 to 7 in f447db1

/// Returns the spec id at the given timestamp.
///
/// Note: This is only intended to be used after the merge, when hardforks are activated by
/// timestamp.
pub fn revm_spec_by_timestamp_after_merge(

should be moved to the corresponding network evm implementations.

this is now possible

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels May 23, 2024
@mattsse mattsse removed the S-needs-triage This issue needs to be labelled label May 23, 2024
@mattsse mattsse self-assigned this May 23, 2024
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label May 23, 2024
@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Jun 27, 2024
@mattsse mattsse assigned joshieDo and unassigned mattsse Jun 27, 2024
@joshieDo joshieDo mentioned this issue Jun 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshieDo joshieDo

Labels
C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move revm_spec methods from reth-primitives to chain specific crates paradigmxyz/reth
2 participants
@mattsse @joshieDo