Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reth-revm crate and layout #7391

Closed
mattsse opened this issue Mar 29, 2024 · 1 comment
Closed

Improve reth-revm crate and layout #7391

mattsse opened this issue Mar 29, 2024 · 1 comment
Assignees
Labels
C-debt A clean up/refactor of existing code C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 29, 2024

Describe the feature

Atm a few things are mangled with optimism features.
The goal is to extract as much as possible to standalone op specific crates.
This has been done with payload builder and txpool crates

op features in the evm/blockexecutor code is the biggest pain point atm.
we already have an evm abstraction which should be the starting point for this.
we need to follow a similar pattern here:

  1. extract the general abstraction (traits)
  2. move ethereum impl to ethereum crate, move optimism impl to op crate

This is similar to #7375 but should be done before #7375

we need:

  • reth-evm: contains all evm related abstractions: ConfigureEvm, for the time being the BlockExecutor traits as well
  • reth-ethereum-evm
  • reth-optimism-evm

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 29, 2024
@mattsse mattsse added C-debt A clean up/refactor of existing code and removed S-needs-triage This issue needs to be labelled labels Mar 29, 2024
@mattsse mattsse self-assigned this Mar 29, 2024
@Rjected
Copy link
Member

Rjected commented Jun 12, 2024

Is there anything left on this?

@mattsse mattsse closed this as completed Jun 12, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code C-enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants