Compatibility with serialized_attributes gem #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct with other gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've been trying to use Paper Trail with the serialized_attributes gem. After much pain and anguish, I figured out that both Paper Trail and SerializedAttributes define the same class method on the model:
serialize_attributes. You can imagine the havoc this caused. =)I think the best solution is to change the method names in Paper Trail. This is because the
serialize_attributesmethod in the Serialized Attributes gem is a public interface. You must call this method in order to enable the gem. In Paper Trail, this method is only used internally. So it should be safe to change the method names in Paper Trail. Another advantage is thatserialize_attributesis a pretty generic method name, which may interfere with other gems, so it's good to make the name more specific to Paper Trail.