-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version table will use uuid as primary key type if uuid flag is set #1414
Version table will use uuid as primary key type if uuid flag is set #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nuzair, looks good. Please add a changelog entry under Unreleased -> Fixed.
This PR has been automatically marked as stale due to inactivity. |
@jaredbeck @Nuzair46 Any updates on this? PaperTrail isn't usable without UUIDs as the item ID |
@jaredbeck Can we get this merged? |
Doing |
It will change to "string" type and which will allow for |
Unfortunately it doesn't generate a string column and manually changing doesn't work. Regardless of the |
Got it. The brackets are not valid. Doing bundle |
Yea. The documentation needs to be updated so that the commands are shown properly. It is a bit confusing right now. |
@jaredbeck this pr has been open for months. can it be merged? |
49b4430
to
f71c88d
Compare
…fied on migration generation removed unwanted changes fixed ci test reset gemspec added changelog
95686bb
to
db46feb
Compare
For future reference, the brackets indicate optionality. This is a documentation convention going back 30+ years. |
Released in 15.0.0 |
Version table will use uuid as primary key type if uuid flag is specified on migration generation
Fix for #1402
followup to #1374
Thank you for your contribution!
Check the following boxes:
master
(if not - rebase it).code introduces user-observable changes.
and description in grammatically correct, complete sentences.