Add specs to request variables branch #1052
Conversation
| @@ -4,6 +4,7 @@ | |||
| .idea | |||
| .rbenv-gemsets | |||
| .rbenv-version | |||
| .rspec_results | |||
There was a problem hiding this comment.
I added this so I could use --next-failure and --only-failures when running rspec, which I use a lot.
There was a problem hiding this comment.
Nice. I use --only-failures on other projects, but I didn't know about --next-failure 👍 Thanks
spec/spec_helper.rb
Outdated
| @@ -10,6 +10,8 @@ | |||
| end | |||
|
|
|||
| RSpec.configure do |config| | |||
| config.example_status_persistence_file_path = '.rspec_results' | |||
There was a problem hiding this comment.
I added this so I could use --next-failure and --only-failures when running rspec, which I use a lot.
|
This looks great, Alex, thanks! I don't normally bother testing delegation of deprecated methods, but I'm happy to have the tests. Later this year, when we remove the deprecated methods, the test will be easy to remove. I also usually avoid However, these are very minor points, and I really appreciate you adding these tests, thanks. |
|
Sure thing! |
@jaredbeck
Added specs that I asked you to add in the original PR, let me know what you think and if I can merge it into your branch.