Allow Sources subclasses to specify the # of expected files
#9466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
Eric-Arellano
commented
Apr 4, 2020
| @@ -6,8 +6,6 @@ | |||
|
|
|||
| from pants.backend.python.subsystems.pytest import PyTest | |||
| from pants.build_graph.address import Address | |||
| from pants.engine.fs import Snapshot | |||
There was a problem hiding this comment.
Most changes in this file only move around code. The only real change is to PythonBinarySources near the top of the file.
Comment on lines
+59
to
+60
| class PythonBinarySources(PythonSources): | ||
| expected_num_files = range(0, 2) |
There was a problem hiding this comment.
The only real change to this file.
# Delete this line to force CI to run Clippy and the Rust tests. [ci skip-rust-tests] # No Rust changes made. # Delete this line to force CI to run the JVM tests. [ci skip-jvm-tests] # No JVM changes made.
benjyw
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twice now, we've had
Sourcesfields that require a specific number of files. So, this PR formalizes a mechanism to do this.Error message #1:
Error message #2:
Error message #3:
[ci skip-rust-tests] # No Rust changes made.
[ci skip-jvm-tests] # No JVM changes made.