Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mypy type error in meta.py #8509

Merged

Conversation

cosmicexplorer
Copy link
Contributor

Problem

pants.util.meta.frozen_after_init has a couple mypy type checking errors, specifically at:

setattr(cls, frozen_after_init.sentinel_attr, True)
return cls
frozen_after_init.sentinel_attr = '_frozen_after_init'

This caused a failure on master, see https://travis-ci.org/pantsbuild/pants/jobs/600466692.

Solution

Result

CI is unbroken!

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm any ideas how this slipped past CI? Did we merge on red?

Thank you for fixing this!

@cosmicexplorer
Copy link
Contributor Author

Yes, I merged on red for #8181, and made a change I didn't realize would break the type checking (the precise change that caused this error, see 00c4f8c#diff-ec31f60c86dc5b36ed1ab04df574c245).

@cosmicexplorer cosmicexplorer merged commit 9ad14d3 into pantsbuild:master Oct 21, 2019
stuhood added a commit to twitter/pants that referenced this pull request Oct 25, 2019
stuhood added a commit that referenced this pull request Oct 25, 2019
Fixes #8539 and #8520.

----

Revert "fix mypy type error in meta.py (#8509)"

This reverts commit 9ad14d3.

----

Revert "support using @DataClass for engine params (#8181)"

This reverts commit 00c4f8c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants