move platform-specific testing to its own subdirectory of python tasks for 1:1:1 #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Nov 30, 2018
|
It looks like some of the CI failures are related to the changes. |
|
The integration test failure (specifically |
cosmicexplorer
force-pushed
the
split-python-native-code-testing-targets-111
branch
from
c8a1665 to
022ed8c
Compare
|
Please ping when this is ready for review (green). |
cosmicexplorer
added a commit
that referenced
this pull request
Jan 25, 2019
…tensions in setup.py (#7126) ### Problem Resolves #7016 (see [mirrored `pants-devel` post](https://groups.google.com/forum/#!topic/pants-devel/Y37d0tf4bKo)). This unblocks #6855 and #7046, as well as further work on #7122. Closes #5661, closes #6841. I also made a long, long-overdue [github project for native code](https://github.com/pantsbuild/pants/projects/11). ### Solution - Use the host environment to invoke compilers and linkers as desired in distutils, don't try to inject our own toolchain. See #5661 and #7016 for why this is extremely difficult to maintain. ### Result Further native backend iteration is unblocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The haphazard distribution of the test targets tagged with
'platform_specific_behavior'intests/python/pants_test/backend/python/tasks/BUILDis not only hard to follow, it also causes mysterious errors -- see this comment on #6816.Solution
'platform_specific_behavior'into a new subdirectory namedplatform_specific_behavior/.