Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] allow selection of the compile/link toolchain for python_dist() #6328

Conversation

cosmicexplorer
Copy link
Contributor

WIP because there is absolutely no testing yet

Problem

There is currently no way for a user to affect which compiler or linker is run at any point in which our native toolchain is invoked. This adds that option for python_dist() targets.

Also, all the random stuff we add to the environment is just confusing distutils and making it produce compile errors in lots of internal usages of python_dist() -- until #6273 is merged, leaving the setup.py invocation environment mostly untouched allows these to succeed.

(explain the context of the problem and why you're making this change. include
references to all relevant github issues.
)

Solution

(describe the modifications you've made.)

Result

(describe how your changes affect the end-user behavior of the system. this section is
optional, and should generally be summarized in the title of the pull request.
)

@cosmicexplorer
Copy link
Contributor Author

This is also obsolete as of #7126, and #6800 does the job of selecting the toolchain for the native backend now anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant