Bound pytest below 3.7 to avoid a ZipImportError #6285
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Jul 31, 2018
|
Blargh. Two isolated_process timeouts in a row. Going to merge. |
Closed
|
Going to eagerly pick this to both 1.8.x and 1.9.x. |
stuhood
pushed a commit
that referenced
this pull request
Aug 1, 2018
### Problem As described in #6282, pytest `3.7` introduces a non-deterministic `ZipImportError`. ### Solution Bound pants' usage of pytest below `3.7`. This subsumes #6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. ### Result Works around #6282.
stuhood
pushed a commit
to twitter/pants
that referenced
this pull request
Aug 1, 2018
### Problem As described in pantsbuild#6282, pytest `3.7` introduces a non-deterministic `ZipImportError`. ### Solution Bound pants' usage of pytest below `3.7`. This subsumes pantsbuild#6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. ### Result Works around pantsbuild#6282.
CMLivingston
pushed a commit
to CMLivingston/pants
that referenced
this pull request
Aug 27, 2018
### Problem As described in pantsbuild#6282, pytest `3.7` introduces a non-deterministic `ZipImportError`. ### Solution Bound pants' usage of pytest below `3.7`. This subsumes pantsbuild#6283: the hypothesis is that because `tests/python/pants_test/backend/python/tasks/test_pytest_run.py` creates synthetic scopes for its tasks, options in `pants.ini` (as opposed to Subsystem defaults) are not applied. ### Result Works around pantsbuild#6282.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As described in #6282, pytest
3.7introduces a non-deterministicZipImportError.Solution
Bound pants' usage of pytest below
3.7. This subsumes #6283: the hypothesis is that becausetests/python/pants_test/backend/python/tasks/test_pytest_run.pycreates synthetic scopes for its tasks, options inpants.ini(as opposed to Subsystem defaults) are not applied.Result
Works around #6282.