Python 3 - fix cffi resolver issues #6225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Jul 24, 2018
| @@ -41,7 +41,7 @@ def execute(self): | |||
| safe_concurrent_rename(pants_wd, tmp_trash) | |||
| safe_concurrent_rename(tmpdir, pants_wd) | |||
|
|
|||
| if self.get_options().async: | |||
| if self.get_options()['async']: | |||
There was a problem hiding this comment.
async is a reserved word in Py3
| new_exception = self.CacheValidationError("Problem validating target {} in {}: {}" | ||
| .format(target.id, target.address.spec_path, e)) | ||
|
|
||
| raise self.CacheValidationError, new_exception, exc_info[2] | ||
| raise_from(self.CacheValidationError(new_exception), e) |
There was a problem hiding this comment.
raise from is Python 3 syntactic sugar that provides the same functionality as exc_info[2].
jsirois
suggested changes
Jul 24, 2018
| @@ -27,7 +27,7 @@ pywatchman==1.4.1 | |||
| requests[security]>=2.5.0,<2.19 | |||
| scandir==1.2 | |||
| setproctitle==1.1.10 | |||
| setuptools==30.0.0 | |||
| setuptools==33.1.1 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Good catch. Fixed with latest commit. Thanks!
jsirois
approved these changes
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When running any unit test that extends
TestBasewith Python 3 on macOS (not tested on Linux), pants throws this exceptionException message: Package SourcePackage(u'file:///Users/earellano/.cache/pants/python_cache/requirements/CPython-3.7.0/cryptography-2.3.tar.gz') is not translateable by ChainedTranslator(WheelTranslator, EggTranslator, SourceTranslator)I realized this is because I didn't have liffbfi and cffi installed, so I followed their install instructions. Our README already specifies you need these, so this is okay so far.
After installing liffbfi and cffi, I ran into a new exception:
Solution
Bumping setuptools to the max possible, 33.1.1, fixes the issue for me, when followed by
./pants clean-allNote that setuptools goes all the way to 40.0, but PEX requires < 34.
To test locally
Add
compatibility='CPython>=3.5',to the:metaentry inpants_test/util/BUILD. Then run./pants test tests/python/pants_test/util:metaWhile the unit test itself will fail, the requirements resolver should pass.